This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
feat(frameworks): Support runner.afterEach in jasmine and mocha ada…
#3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliemr
approved these changes
Jan 19, 2017
sjelin
force-pushed
the
supportAfterEach
branch
2 times, most recently
from
823d5eb
to
aef570c
Compare
sjelin
force-pushed
the
supportAfterEach
branch
from
aef570c
to
0ada6d5
Compare
sjelin
commented
Jan 20, 2017
| @@ -76,7 +76,7 @@ executor.addCommandlineTest('node built/cli.js spec/errorTest/timeoutConf.js') | |||
| message: 'Timeout - Async callback was not invoked within timeout ' + | |||
| 'specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.' | |||
| }) | |||
| .expectTestDuration(0, 100); | |||
| .expectTestDuration(0, 1000); | |||
There was a problem hiding this comment.
After a lot of bench-marking, I have concluded that this change only matters for extremely short tests like this one, and shouldn't matter to normal users.
sjelin
added a commit
that referenced
this pull request
Jan 23, 2017
sjelin
added a commit
that referenced
this pull request
Jan 26, 2017
sjelin
added a commit
to sjelin/protractor
that referenced
this pull request
Jan 27, 2017
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pter
Closes #3894,
#3908, and
#3909